Changeset 1216

Timestamp:

Nov 14, 2008 12:19:10 AM (15 years ago)

Author:

dkearney

Message:

adding fix to controls.tcl to properly display all enabled tabs when some of the available tabs are disabled. this fix helps allow photonicsdb to dynamically display inputs for layers of materials while keeping the first and last tabs always enabled.

also included is an example which displays the bad behavior in previous versions of rappture as part of the buggy_xml series.

Location:

trunk

Files:

• gui/scripts/controls.tcl (modified) (3 diffs)
• test/buggy_xmls (added)
• test/buggy_xmls/disabledtabs (added)
• test/buggy_xmls/disabledtabs/readme (added)
• test/buggy_xmls/disabledtabs/tool.xml (added)

trunk/gui/scripts/controls.tcl

@@ -47 +47 @@
     private variable _dispatcher ""  ;# dispatcher for !events
     private variable _controls ""    ;# list of known controls
+    private variable _showing ""     ;# list of enabled (showing) controls
     private variable _name2info      ;# maps control name => info
     private variable _scheme ""      ;# layout scheme (tabs/hlabels)
@@ -446 +447 @@
     }
 
+    # store the showing tabs in the object so it can be used in _changeTabs
+    set _showing $showing
+
     #
     # Decide on a layout scheme:
@@ -689 +693 @@
 itcl::body Rappture::Controls::_changeTabs {} {
     set i [$_tabs index select]
-    set name [lindex $_controls $i]
+    # we use _showing here instead of _controls because sometimes tabs
+    # are disabled, and the index of the choosen tab always matches
+    # _showing, even if tabs are disabled.
+    set name [lindex $_showing $i]
     if {"" != $name} {
         foreach w [grid slaves $_frame] {