Changeset 1366 for trunk/src/core/RpEncode.h

Timestamp:

Mar 27, 2009 4:54:09 PM (14 years ago)

Author:

gah

Message:

Begin reorganizing Rappture C++ API, starting with the use of
Rappture::Outcome.

Instead of returning an Outcome and expecting every routine to
save it, pass it as a reference. Let's strip it down to what's
needed right now and add back functionality as required.

Right now too many return values are ignored in the rappture library.
We need to check all results and return the error messages via
the Outcome. At the topmost level where is touches the developer
API we can drop the error checking or turn it on via an environment
variable.

Example. Not enough checks are made for memory allocation failure.
If the application is running on an over-committed server memory
allocation errors will be silently passed on. It's okay to be
fault tolerant where possible, but if we fail to check in the internal
library functions, it's too late.

--gah

File:

• trunk/src/core/RpEncode.h (modified) (1 diff)

trunk/src/core/RpEncode.h

@@ -15 +15 @@
 #define RAPPTURE_ENCODE_H
 
+#include <RpOutcome.h>
 #include <RpBuffer.h>
-#include <RpOutcome.h>
 
-#define RPENC_Z      1
-#define RPENC_B64    2
-#define RPENC_HDR    4
+namespace Rappture {
+namespace encoding {
 
-#ifdef __cplusplus
-extern "C" {
-namespace Rappture {
-    namespace encoding {
-#endif // ifdef __cplusplus
+#define RPENC_Z      (1<<0)
+#define RPENC_B64    (1<<1)
+#define RPENC_HDR    (1<<2)
 
 int isbinary(const char* buf, int size);
 size_t isencoded(const char* buf, int size);
-Rappture::Outcome encode (Rappture::Buffer& buf, size_t flags);
-Rappture::Outcome decode (Rappture::Buffer& buf, size_t flags);
+bool encode(Rappture::Outcome &err, Rappture::Buffer& buf, size_t flags);
+bool decode(Rappture::Outcome &err, Rappture::Buffer& buf, size_t flags);
 
-#ifdef __cplusplus
-    } // namespace encoding
-} // namespace Rappture
-} // extern C
-#endif // ifdef __cplusplus
-
+}
+}
 #endif // RAPPTURE_ENCODE_H