Changeset 2167

Timestamp:

Mar 30, 2011 11:07:37 AM (13 years ago)

Author:

mmc

Message:

Added a fix to guard against missing/duplicate test names when loading
test cases. It now prints a message to standard error and skips the
malformed test.

Fixed a bug when you regoldenize a test then try to run it again. It
runs cleanly now.

Location:

trunk/tester/scripts

Files:

• main.tcl (modified) (1 diff)
• test.tcl (modified) (1 diff)

trunk/tester/scripts/main.tcl

@@ -297 +297 @@
 foreach file [glob -nocomplain -directory $params(-testdir) *.xml] {
     set testobj [Rappture::Tester::Test ::#auto $ToolObj $file]
-    $testtree add $testobj
+    if {[$testobj getTestInfo test.label] eq ""} {
+        puts stderr "ERROR:  Missing test label in $file"
+        puts stderr "        skipping that test..."
+    } elseif {[catch {$testtree add $testobj} err]} {
+        puts stderr "ERROR:  Can't load test $file"
+        puts stderr "        $err"
+        puts stderr "        skipping that test..."
+    }
 }
 $testtree component treeview open -recurse root

trunk/tester/scripts/test.tcl

@@ -249 +249 @@
     itcl::delete object $_testobj
     set _testobj $_runobj
+    set _runobj ""
 
     set _diffs ""