Changeset 3184

Timestamp:

Oct 17, 2012, 11:13:03 AM (12 years ago)

Author:

clarksm

Message:

Do a better job when command is given as string. Eliminating the intermediate shell script allows the kill signal to propagate.

File:

• trunk/lang/python/Rappture/tools.py (modified) (3 diffs)

trunk/lang/python/Rappture/tools.py

@@ -11 +11 @@
 import re
 import subprocess
+import shlex
 import select
 import signal
@@ -37 +38 @@
                                 close_fds=True)
     else:
-       child = subprocess.Popen(command,shell=True,bufsize=BUFSIZ, \
+       commandArgs = shlex.split(command)
+       child = subprocess.Popen(commandArgs,bufsize=BUFSIZ, \
                                 stdout=subprocess.PIPE, \
                                 stderr=subprocess.PIPE, \
@@ -120 +122 @@
     else:
         raise RuntimeError, 'could not open %s for writing' % (fileName)
+