Changeset 3188

Timestamp:

Oct 23, 2012 5:23:10 AM (12 years ago)

Author:

mmc

Message:

Added unexpected bug reports to the logger as "oops!" messages.
Fixed the HeightmapViewer? to log user events properly (not just any
internal call to change view parameters).

Location:

trunk/gui/scripts

Files:

• bugreport.tcl (modified) (2 diffs)
• heightmapviewer.tcl (modified) (9 diffs)

trunk/gui/scripts/bugreport.tcl

@@ -1 @@
-
 # ----------------------------------------------------------------------
 #  UTILITY: bugreport
@@ -432 +431 @@
     set details(referrer) [Rappture::Tool::resources -appname]
     set details(platform) [array get tcl_platform]
+
+    Rappture::Logger::log oops! $summary
 }
 

trunk/gui/scripts/heightmapviewer.tcl

@@ -91 +91 @@
 
     protected method State {comp}
-    protected method FixSettings {what {value ""} {why -program}}
+    protected method FixSettings {what {why -program}}
     protected method GetTransfuncData {dataobj comp}
     protected method Resize {}
@@ -1042 +1042 @@
 
 # ----------------------------------------------------------------------
-# USAGE: FixSettings <what> ?<value>? ?-user|-program?
+# USAGE: FixSettings <what> ?-user|-program?
 #
 # Used internally to update rendering settings whenever parameters
@@ -1048 +1048 @@
 # to the back end.
 # ----------------------------------------------------------------------
-itcl::body Rappture::HeightmapViewer::FixSettings { what {value ""} {why -program} } {
+itcl::body Rappture::HeightmapViewer::FixSettings {what {why -program}} {
     switch -- $what {
         "legend" {
@@ -1069 +1069 @@
                 #$itk_component(legend) delete all
             }
-            Rappture::Logger::log heightmap legend $_settings($this-legend)
+            if {$why eq "-user"} {
+                Rappture::Logger::log heightmap legend $_settings($this-legend)
+            }
         }
         "surface" {
@@ -1075 +1077 @@
                 SendCmd "heightmap data visible $_settings($this-surface)"
             }
-            Rappture::Logger::log heightmap surface $_settings($this-surface)
+            if {$why eq "-user"} {
+                Rappture::Logger::log heightmap surface $_settings($this-surface)
+            }
         }
         "grid" {
@@ -1081 +1085 @@
                 SendCmd "grid visible $_settings($this-grid)"
             }
-            Rappture::Logger::log heightmap grid $_settings($this-grid)
+            if {$why eq "-user"} {
+                Rappture::Logger::log heightmap grid $_settings($this-grid)
+            }
         }
         "axes" {
@@ -1087 +1093 @@
                 SendCmd "axis visible $_settings($this-axes)"
             }
-            Rappture::Logger::log heightmap axes $_settings($this-axes)
+            if {$why eq "-user"} {
+                Rappture::Logger::log heightmap axes $_settings($this-axes)
+            }
         }
         "wireframe" {
@@ -1093 +1101 @@
                 SendCmd "heightmap polygon $_settings($this-wireframe)"
             }
-            Rappture::Logger::log heightmap wireframe $_settings($this-wireframe)
+            if {$why eq "-user"} {
+                Rappture::Logger::log heightmap wireframe $_settings($this-wireframe)
+            }
         }
         "contourlines" {
@@ -1106 +1116 @@
                 }
             }
-            Rappture::Logger::log heightmap contourlines $_settings($this-contourlines)
+            if {$why eq "-user"} {
+                Rappture::Logger::log heightmap contourlines $_settings($this-contourlines)
+            }
         }
         default {