Changeset 3581

Timestamp:

Mar 25, 2013, 3:56:17 PM (11 years ago)

Author:

gah

Message:

fix regression: was not comparing pattern when compiling list of matching components

File:

• trunk/gui/scripts/field.tcl (modified) (1 diff)

trunk/gui/scripts/field.tcl

@@ -262 +262 @@
     # BE CAREFUL: return component names in proper order
     set rlist ""
-    set components [$_field children -type component]
+    set components {}
+    # First compile a list of valid components that match the pattern
+    foreach cname [$_field children -type component] {
+        if { ![info exists _isValidComponent($cname)] } {
+            continue
+        }
+        if { [string match $pattern $cname] } {
+            lappend components $cname
+        }
+    }
+    # Now handle the tests.
     switch -- $params(what) {
         -name { 
-            foreach cname $components {
-                if { [info exists _isValidComponent($cname)] } {
-                    lappend rlist $cname 
-                }
-            }
+            set rlist $components
         }
         -style { 
             foreach cname $components {
-                if { ![info exists _isValidComponent($cname)] } {
-                    continue
-                }
                 if { [info exists _comp2style($cname)] } {
                     lappend rlist $_comp2style($cname)