Changeset 4422

Timestamp:

Jun 25, 2014 12:58:19 AM (9 years ago)

Author:

ldelgass

Message:

Fix crash bug in user errors: was returning pointer to temporary. Return a
copy of string object from getUserMessages instead of pointer.

Location:

trunk/packages/vizservers

Files:

• geovis/RendererCmd.cpp (modified) (1 diff)
• geovis/Trace.cpp (modified) (1 diff)
• geovis/Trace.h (modified) (2 diffs)
• nanovis/Command.cpp (modified) (1 diff)
• nanovis/Trace.cpp (modified) (1 diff)
• nanovis/Trace.h (modified) (2 diffs)
• vtkvis/RendererCmd.cpp (modified) (2 diffs)
• vtkvis/Trace.cpp (modified) (1 diff)
• vtkvis/Trace.h (modified) (2 diffs)

trunk/packages/vizservers/geovis/RendererCmd.cpp

@@ -1852 +1852 @@
     }
 
-    string = getUserMessages();
-    nBytes = strlen(string);
+    std::string msg = getUserMessages();
+    nBytes = msg.length();
     if (nBytes > 0) {
+        string = msg.c_str();
         TRACE("userError=(%s)", string);
 
         std::ostringstream oss;
         oss << "nv>viserror -type error -token " << g_stats.nCommands << " -bytes " << nBytes << "\n" << string;
-        nBytes = oss.str().length();
-
-        if (queueResponse(oss.str().c_str(), nBytes, Response::VOLATILE, Response::ERROR) < 0) {
+        std::string ostr = oss.str();
+        nBytes = ostr.length();
+
+        if (queueResponse(ostr.c_str(), nBytes, Response::VOLATILE, Response::ERROR) < 0) {
             return -1;
         }

trunk/packages/vizservers/geovis/Trace.cpp

@@ -88 +88 @@
 }
 
-const char *
+std::string
 GeoVis::getUserMessages()
 {
-    return g_UserErrorString.str().c_str();
+    return g_UserErrorString.str();
 }
 

trunk/packages/vizservers/geovis/Trace.h

@@ -9 +9 @@
 #define GEOVIS_TRACE_H
 
+#include <string>
+
 #include <syslog.h>
 
@@ -15 +17 @@
 extern void logUserMessage(const char* format, ...);
 
-extern const char *getUserMessages();
+extern std::string getUserMessages();
 
 extern void clearUserMessages();

trunk/packages/vizservers/nanovis/Command.cpp

@@ -2315 +2315 @@
     }
 
-    string = getUserMessages();
-    nBytes = strlen(string);
+    std::string msg = getUserMessages();
+    nBytes = msg.length();
     if (nBytes > 0) {
+        string = msg.c_str();
         TRACE("userError=(%s)", string);
 
         std::ostringstream oss;
         oss << "nv>viserror -type error -token " << g_stats.nCommands << " -bytes " << nBytes << "\n" << string;
-        nBytes = oss.str().length();
+        std::string ostr = oss.str();
+        nBytes = ostr.length();
 
 #ifdef USE_THREADS
-        queueResponse(oss.str().c_str(), nBytes, Response::VOLATILE, Response::ERROR);
+        queueResponse(ostr.c_str(), nBytes, Response::VOLATILE, Response::ERROR);
 #else
-        if (write(fdOut, oss.str().c_str(), nBytes) < 0) {
+        if (write(fdOut, ostr.c_str(), nBytes) < 0) {
             ERROR("write failed: %s", strerror(errno));
             return -1;

trunk/packages/vizservers/nanovis/Trace.cpp

@@ -90 +90 @@
 }
 
-const char *
+std::string
 nv::getUserMessages()
 {
-    return g_UserErrorString.str().c_str();
+    return g_UserErrorString.str();
 }
 

trunk/packages/vizservers/nanovis/Trace.h

@@ -8 +8 @@
 #ifndef NV_TRACE_H
 #define NV_TRACE_H
+
+#include <string>
 
 #include <GL/glew.h>
@@ -22 +24 @@
 extern void logUserMessage(const char* format, ...);
 
-extern const char *getUserMessages();
+extern std::string getUserMessages();
 
 extern void clearUserMessages();

trunk/packages/vizservers/vtkvis/RendererCmd.cpp

@@ -13122 +13122 @@
             std::ostringstream oss;
             oss << "nv>viserror -type internal_error -token " << g_stats.nCommands << " -bytes " << nBytes << "\n" << string;
-            nBytes = oss.str().length();
+            std::string ostr = oss.str();
+            nBytes = ostr.length();
 
 #ifdef USE_THREADS
-            queueResponse(clientData, oss.str().c_str(), nBytes, Response::VOLATILE, Response::ERROR);
+            queueResponse(clientData, ostr.c_str(), nBytes, Response::VOLATILE, Response::ERROR);
 #else
-            if (write(fdOut, oss.str().c_str(), nBytes) < 0) {
+            if (write(fdOut, ostr.c_str(), nBytes) < 0) {
                 ERROR("write failed: %s", strerror(errno));
                 return -1;
@@ -13135 +13136 @@
     }
 
-    string = getUserMessages();
-    nBytes = strlen(string);
+    std::string msg = getUserMessages();
+    nBytes = msg.length();
     if (nBytes > 0) {
+        string = msg.c_str();
         TRACE("userError=(%s)", string);
 
         std::ostringstream oss;
         oss << "nv>viserror -type error -token " << g_stats.nCommands << " -bytes " << nBytes << "\n" << string;
-        nBytes = oss.str().length();
+        std::string ostr = oss.str();
+        nBytes = ostr.length();
 
 #ifdef USE_THREADS
-        queueResponse(clientData, oss.str().c_str(), nBytes, Response::VOLATILE, Response::ERROR);
+        queueResponse(clientData, ostr.c_str(), nBytes, Response::VOLATILE, Response::ERROR);
 #else
-        if (write(fdOut, oss.str().c_str(), nBytes) < 0) {
+        if (write(fdOut, ostr.c_str(), nBytes) < 0) {
             ERROR("write failed: %s", strerror(errno));
             return -1;

trunk/packages/vizservers/vtkvis/Trace.cpp

@@ -88 +88 @@
 }
 
-const char *
+std::string
 VtkVis::getUserMessages()
 {
-    return g_UserErrorString.str().c_str();
+    return g_UserErrorString.str();
 }
 

trunk/packages/vizservers/vtkvis/Trace.h

@@ -9 +9 @@
 #define VTKVIS_TRACE_H
 
+#include <string>
+
 #include <syslog.h>
 
@@ -15 +17 @@
 extern void logUserMessage(const char* format, ...);
 
-extern const char *getUserMessages();
+extern std::string getUserMessages();
 
 extern void clearUserMessages();