Changeset 4422 for trunk/packages/vizservers/vtkvis/RendererCmd.cpp

Timestamp:

Jun 25, 2014 12:58:19 AM (7 years ago)

Author:

ldelgass

Message:

Fix crash bug in user errors: was returning pointer to temporary. Return a
copy of string object from getUserMessages instead of pointer.

File:

• trunk/packages/vizservers/vtkvis/RendererCmd.cpp (modified) (2 diffs)

trunk/packages/vizservers/vtkvis/RendererCmd.cpp

@@ -13122 +13122 @@
             std::ostringstream oss;
             oss << "nv>viserror -type internal_error -token " << g_stats.nCommands << " -bytes " << nBytes << "\n" << string;
-            nBytes = oss.str().length();
+            std::string ostr = oss.str();
+            nBytes = ostr.length();
 
 #ifdef USE_THREADS
-            queueResponse(clientData, oss.str().c_str(), nBytes, Response::VOLATILE, Response::ERROR);
+            queueResponse(clientData, ostr.c_str(), nBytes, Response::VOLATILE, Response::ERROR);
 #else
-            if (write(fdOut, oss.str().c_str(), nBytes) < 0) {
+            if (write(fdOut, ostr.c_str(), nBytes) < 0) {
                 ERROR("write failed: %s", strerror(errno));
                 return -1;
@@ -13135 +13136 @@
     }
 
-    string = getUserMessages();
-    nBytes = strlen(string);
+    std::string msg = getUserMessages();
+    nBytes = msg.length();
     if (nBytes > 0) {
+        string = msg.c_str();
         TRACE("userError=(%s)", string);
 
         std::ostringstream oss;
         oss << "nv>viserror -type error -token " << g_stats.nCommands << " -bytes " << nBytes << "\n" << string;
-        nBytes = oss.str().length();
+        std::string ostr = oss.str();
+        nBytes = ostr.length();
 
 #ifdef USE_THREADS
-        queueResponse(clientData, oss.str().c_str(), nBytes, Response::VOLATILE, Response::ERROR);
+        queueResponse(clientData, ostr.c_str(), nBytes, Response::VOLATILE, Response::ERROR);
 #else
-        if (write(fdOut, oss.str().c_str(), nBytes) < 0) {
+        if (write(fdOut, ostr.c_str(), nBytes) < 0) {
             ERROR("write failed: %s", strerror(errno));
             return -1;