Changeset 6503

Timestamp:

Aug 29, 2016 3:21:20 PM (7 years ago)

Author:

ldelgass

Message:

Close syslog before closing and duping file descriptors above 2 in case it is
using one of them. This can happen if a log message is written before opening
the listening sockets, for example.

File:

• nanoscale/trunk/server.c (modified) (2 diffs)

nanoscale/trunk/server.c

@@ -308 +308 @@
     f = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
     if (f < 0) {
-        Tcl_AppendResult(interp, "can't create listerner socket for \"",
+        Tcl_AppendResult(interp, "can't create listener socket for \"",
                 serverPtr->name, "\": ", Tcl_PosixError(interp), (char *)NULL);
         goto error;
@@ -606 +606 @@
                     }
                 }
+                /* Make sure to close syslog in case it is using one of
+                 * the file descriptors we are about to close
+                 */
+                closelog();
                 /* Dup the socket to descriptors, e.g. 3 and 4 */
                 if (dup2(sock, serverPtr->inputFd) < 0)  { /* input */